-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port: tgui loadout + tgui color picker #6280
Open
dageavtobusnick
wants to merge
11
commits into
ss220-space:master220
Choose a base branch
from
dageavtobusnick:port_tgui_loadout_menu_fixed
base: master220
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
port: tgui loadout + tgui color picker #6280
dageavtobusnick
wants to merge
11
commits into
ss220-space:master220
from
dageavtobusnick:port_tgui_loadout_menu_fixed
+3,920
−1,091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
TGUI
Affects TGUI
javascript
Pull requests that update Javascript code
labels
Dec 27, 2024
dageavtobusnick
force-pushed
the
port_tgui_loadout_menu_fixed
branch
from
December 27, 2024 22:27
ec4e931
to
48d54fa
Compare
dageavtobusnick
force-pushed
the
port_tgui_loadout_menu_fixed
branch
from
December 27, 2024 22:47
b12fa0a
to
48d54fa
Compare
dageavtobusnick
force-pushed
the
port_tgui_loadout_menu_fixed
branch
from
December 28, 2024 01:32
6dd2dc5
to
48d54fa
Compare
Antoonij
reviewed
Dec 28, 2024
Co-authored-by: Antoonij <[email protected]>
Co-authored-by: Antoonij <[email protected]>
Co-authored-by: Antoonij <[email protected]>
Co-authored-by: Antoonij <[email protected]>
Co-authored-by: Antoonij <[email protected]>
Co-authored-by: Antoonij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Портирует с https://github.com/ParadiseSS13 лоадаут и выбор цвета(нужен для работы выбора цвета вещей в лодауте), а так же несколько компонентов, нужных для их работы.
Есть изменение относительно офов. Добавлена визуализация изменений? производимых с помощью gear tweaks, в меню экипированного.
Был взят код со следующих ПР:
ParadiseSS13/Paradise#27026
ParadiseSS13/Paradise#26326
ParadiseSS13/Paradise#26623
ParadiseSS13/Paradise#26490
ParadiseSS13/Paradise#27187
ParadiseSS13/Paradise#26895
Причина создания ПР / Почему это хорошо для игры
Новые, более современые, удобные и приятные глазу лоадаут и выбор цвета
Демонстрация изменений
Тесты
Запустил локалку с бд, там настроил лоадаут на старом интерфейсе. После изменений загрузил на новом, все грузится. Изменения сохраняются в бд, сортировка, поиск, выбор подтипов и цвета работают. Экипируется все корректно.
Выбор цвета проверил в преференсах, все выбирается и сохраняется.