Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Лодауты #379

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

Лодауты #379

wants to merge 32 commits into from

Conversation

msw7007
Copy link

@msw7007 msw7007 commented Jul 15, 2024

About The Pull Request

Добавляет новые категории лодаутов, закидывает наши вещи из лодаутов, несколько вещей из ТГ раскидывает по категориям.
Мимоходом добавляет рабочий HEV ибо он находится в наших вещах и муз инструменты ибо они находятся в лодауте

Why It's Good For The Game

Потому-что закрываем иссью 359

Changelog

🆑
add: Категории лодаутов и вещи в них
/:cl:
closes #359

@github-actions github-actions bot added 🔉 Звук Вау... этот звук такой... хуёвый? 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! labels Jul 15, 2024
@dj-34
Copy link
Collaborator

dj-34 commented Jul 15, 2024

ну и как это ревьювить?
мне кажется стоило закинуть сначала вещи отдельно, а другим ПРом закинуть их в лодаут, но хз

@msw7007
Copy link
Author

msw7007 commented Jul 15, 2024

ну и как это ревьювить? мне кажется стоило закинуть сначала вещи отдельно, а другим ПРом закинуть их в лодаут, но хз

Разделить возможно, но там получится что один за другим будут. А так я старался раскидать все по разным папкам

@larentoun
Copy link
Collaborator

Разделить бы код

@msw7007
Copy link
Author

msw7007 commented Jul 23, 2024

Разделить бы код

Как именно?

@larentoun
Copy link
Collaborator

Разделить бы код

Как именно?

На несколько разных ПРов

@Gaxeer Gaxeer added the Do Not Merge Не заливать. В ожидании хэда/хоста. Или просто временный тестмерж. label Jul 23, 2024
@github-actions github-actions bot removed 🔉 Звук Вау... этот звук такой... хуёвый? 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! labels Jul 23, 2024
@msw7007 msw7007 marked this pull request as draft July 23, 2024 11:10
Copy link

github-actions bot commented Aug 2, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Aug 2, 2024
@Gaxeer Gaxeer added RED LABEL PR не может быть устаревшим. Видать кто-то подкупил хэда. and removed Stale labels Aug 2, 2024
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Aug 10, 2024
@Gaxeer Gaxeer removed the Stale label Aug 13, 2024
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Aug 21, 2024
@Gaxeer Gaxeer removed the Stale label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Не заливать. В ожидании хэда/хоста. Или просто временный тестмерж. RED LABEL PR не может быть устаревшим. Видать кто-то подкупил хэда.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Добавить наши шмоточки в лодаут
4 participants