Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyberiad: Polish & fix some ghetto areas #944

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

dj-34
Copy link
Collaborator

@dj-34 dj-34 commented Dec 30, 2024

  1. Пофиксил наименования некоторых зон в гетто Кибериады, например Brig Maintenance, который по факту является нижним этажом Брига.
  2. Добавил больше конкретики в названия зон.

Summary by Sourcery

Renamed and clarified the names of several areas in the Cyberiad station, especially those in the ghetto. Added "Lower Floor" to areas that are located beneath other departments.

Copy link

sourcery-ai bot commented Dec 30, 2024

Reviewer's Guide by Sourcery

This pull request polishes the Cyberiad station map, primarily focusing on improving the naming conventions within the ghetto areas. It clarifies the purpose and location of various areas, providing more context and detail.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved area names in the ghetto section of the Cyberiad station map.
  • Added "Lower Floor" suffix to several ghetto area names to indicate their location relative to the main station.
  • Clarified names like "Brig Maintenance" to "Brig Lower Floor" for better accuracy.
  • Added more specific names for areas like the Cargo Bay Depot and Atmospherics Mixing Room.
  • Renamed some maintenance areas to reflect their abandoned state, such as the Medbay and Garden.
  • Added new abandoned areas like the Bar and Gambling Den.
modular_bandastation/mapping/code/areas/station.dm
Minor map adjustments.
  • Adjusted the order of area definitions in the station.dm file.
  • Modified the Cyberiad.dmm map file (specific changes not detailed in the diff).
_maps/map_files/Cyberiad/Cyberiad.dmm
modular_bandastation/mapping/code/areas/station.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один. label Dec 30, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dj-34 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Fix spelling of 'Abadonned' to 'Abandoned' in area names
  • Consider standardizing the naming pattern between 'Ghetto Abandoned X' and 'Ghetto Abadonned X' to use consistent terminology
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

modular_bandastation/mapping/code/areas/station.dm Outdated Show resolved Hide resolved
Copy link
Collaborator

@AyIong AyIong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Люблю изменения зон

@dj-34 dj-34 force-pushed the cyberiad_polish_ghetto_areas branch from 50883e0 to d409830 Compare December 30, 2024 23:05
@dj-34 dj-34 merged commit 234d523 into ss220club:master Dec 30, 2024
20 of 24 checks passed
@dj-34 dj-34 deleted the cyberiad_polish_ghetto_areas branch December 30, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ Изменение Карты В этом ПРе затронут файл не станционной карты. Может и не один.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants