Add publishing of message type for exclusion of members #72

Powersource · 2023-07-21T09:48:32Z

Stop relying on keyring for listing members #74 Don't use member functions from keyring #75
Test that the member gets excluded for the excluder Person excluding should see exclusion of members #73
Excluded members should exclude themselves #80
Test that a third member sees the exclusion and does something about it
Fix the member tangle #76
Allow being added back into a group after exclusion #79

Powersource · 2023-07-21T09:59:04Z

i guess tests are just flaky or something?

Powersource · 2023-07-21T11:25:14Z

all tests passing locally

Powersource · 2023-07-23T14:27:30Z

test/api/exclude-members.test.js

+
+      tangles: {
+        members: { root: groupInitMsg.key, previous: [groupInitMsg.key] },
+        group: { root: groupInitMsg.key, previous: [...exclude.content.tangles.group.previous] }


is this cheating?

i would say no.

buuut, there seemed to be two entries in the array, which is weird

🌶️ should be same as tangles.members.previous I think

mm yeah but problem is the members tangle doesn't work yet. there was another review comment about this, i'll make an issue

putting this as a later task if that's fine

test/generate/README.md

Powersource · 2023-07-23T14:30:43Z

test/api/exclude-members.test.js

+  }
+
+  await Promise.all([
+    p(kaitiaki.close)(true),


tribes.excludeMembers ✔ creates group kaitiaki ─> new person 1 [?] 2 [?] 3 group/add-member ─ new person, undefined /home/me/prj/ssb/ssb-tribes/index.js:108 if (err) throw err ^ Error [ReadError]: Database is not open at maybeError (/home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/levelup/lib/levelup.js:339:32) at LevelUP.put (/home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/levelup/lib/levelup.js:211:7) at registerAuthor (/home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/ssb-keyring/models/membership.js:45:8) at /home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/ssb-keyring/models/membership.js:26:41 at /home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/async-map.js:32:13 at /home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/pull-stream/sources/values.js:21:7 at next (/home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/async-map.js:27:9) at next (/home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/pull-stream/sinks/drain.js:22:11) at /home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/pull-stream/sinks/drain.js:37:15 at /home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/async-map.js:39:20 { [cause]: undefined } Node.js v18.16.0 ✔ kaitiaki excluded everyone test count(48) != plan(null) Failed tests: There was 1 failure ✖ undefined) undefined total: 48 passing: 48 failing: 1 2.529 s

fixed by adding a 500ms wait at the end and a t.end(), weird 4c98a4a

we never needed t.end() in promise tests in tribes2, i wonder what's the difference. and what exactly is happening in the 500ms wait

that error says that levelDB is trying to do something with a DB which is not open.

at registerAuthor (/home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/ssb-keyring/models/membership.js:45:8)

it's trying to call registerAuthor in the keyring... but I guess the keyring was closed (unless you waited 500ms)

does the keyring open again after 500ms? that's really confusing

Powersource · 2023-07-25T15:36:32Z

All tests passing locally.

I guess before un-marking as draft, I should also add basic "consumption" of the msg. I'll add tasks above.

Powersource · 2023-07-25T17:15:45Z

hmm maybe for "exclusion v1" i can keep this branch as a feature branch. then we could review and approve this branch in its current state, then the other tasks i've listed above can get their own PRs based on this PR. or something like that

mixmix

Looking good. Doesn't have (that I can see) any changes to the listeners which react to the group/exclude-member yet

README.md

mixmix · 2023-08-13T22:50:30Z

method/group.js

+        tangles: {
+          members: {
+            root,
+            previous: [root] // TODO calculate previous for members tangle


made an issue for this that we can do later #76

spec/group/exclude-member.js

mixmix · 2023-08-13T22:58:23Z

test/api/exclude-members.test.js

+  const kaitiaki = Server()
+  const newPerson = Server()
+
+  const name = id => {
+    if (id === kaitiaki.id) return 'kaitiaki '
+    if (id === newPerson.id) return 'new person'
+  }


latest scuttle-testbot supports this

Suggested change

const kaitiaki = Server()

const newPerson = Server()

const name = id => {

if (id === kaitiaki.id) return 'kaitiaki '

if (id === newPerson.id) return 'new person'

}

const kaitiaki = Server({ name: 'kaitiaki' })

const newPerson = Server({ name: 'new-person' })

This, however, is not using the latest scuttle-testbot 😉

mixmix · 2023-08-13T22:58:38Z

test/api/exclude-members.test.js

+      groupId, authorIds, {}
+    )
+
+    await p(replicate)({ from: kaitiaki, to: newPerson, live: false, name })


Suggested change

await p(replicate)({ from: kaitiaki, to: newPerson, live: false, name })

await p(replicate)({ from: kaitiaki, to: newPerson, live: false })

keeping this until we upgrade the testbot in another PR

mixmix · 2023-08-13T23:00:36Z

test/api/exclude-members.test.js

+      excludes: authorIds,
+
+      tangles: {
+        members: { root: groupInitMsg.key, previous: [groupInitMsg.key] },


🌶️ I think the previous should be the id of the invite message

mixmix · 2023-08-13T23:01:43Z

test/api/exclude-members.test.js

+
+      tangles: {
+        members: { root: groupInitMsg.key, previous: [groupInitMsg.key] },
+        group: { root: groupInitMsg.key, previous: [...exclude.content.tangles.group.previous] }


🌶️ should be same as tangles.members.previous I think

mixmix · 2023-08-13T23:04:05Z

test/api/exclude-members.test.js

+  }
+
+  await Promise.all([
+    p(kaitiaki.close)(true),


that error says that levelDB is trying to do something with a DB which is not open.

at registerAuthor (/home/me/prj/ssb/ssb-tribes/node_modules/.pnpm/[email protected]/node_modules/ssb-keyring/models/membership.js:45:8)

it's trying to call registerAuthor in the keyring... but I guess the keyring was closed (unless you waited 500ms)

Co-authored-by: mix irving <[email protected]>

Powersource · 2023-08-16T10:36:18Z

thanks for the review ❤️

Doesn't have (that I can see) any changes to the listeners which react to the group/exclude-member yet

yeah i'm thinking that's for the other PRs that would merge into this one before we merge this

Co-authored-by: mix irving <[email protected]>

…keyring-no-members

Powersource · 2023-09-05T14:12:53Z

merged #75 into this since that PR is close to getting into master and we need that + this PR to be able to do #73

socket-security · 2023-09-05T14:17:15Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
private-group-spec	8.0.0	filesystem	`+0`	75.7 kB	powersource

mixmix · 2023-09-18T05:28:24Z

Merged via : #83

Powersource · 2023-09-18T16:49:01Z

Gonna track this in #85 instead

Start documenting exclusion

ee00adc

Powersource requested a review from mixmix July 21, 2023 09:48

Powersource added 2 commits July 21, 2023 12:08

Elaborate on exclusion members tangle

b4bb041

Update private-group-spec and copy old vectors from there

044747a

Powersource added 3 commits July 21, 2023 13:30

Add exclude-member validator

1ff4a57

Also use sigil msg links in exclude msgs

d236514

Add an exclude test and try to get it to pass

bdbfea3

Powersource commented Jul 23, 2023

View reviewed changes

test/generate/README.md Show resolved Hide resolved

Powersource commented Jul 23, 2023

View reviewed changes

Fix exclude test

4c98a4a

Auto lint

8e9c1ff

Powersource changed the title ~~Add basic exclusion of members~~ Add publishing of message type for exclusion of members Jul 25, 2023

Powersource marked this pull request as ready for review July 25, 2023 17:17

This was referenced Jul 25, 2023

Person excluding should see exclusion of members #73

Closed

Stop relying on keyring for listing members #74

Closed

Powersource added 4 commits July 27, 2023 16:37

Rewrite listAuthors to not use keyring

925479c

Ignore pnpm lock

258cacd

Don't use keyring listAuthors to setup replication

8d5c6bf

Remove tribes.registerAuthors

45bf22b

mixmix reviewed Aug 13, 2023

View reviewed changes

Make exclusion warning in readme more prominent

661f1c3

Co-authored-by: mix irving <[email protected]>

Powersource added 3 commits August 16, 2023 15:26

Stop depending on keyring.processAddMembers

cb0cfd0

Lint

d4db5ff

Try to log more on invite test err

12bf6be

mixmix and others added 17 commits September 4, 2023 17:01

upgrade [email protected]

9315d07

try to upgrade npm before npm ci

9549e77

npm i -g npm@9

c14eebb

revert lockfile to v2

9b79ff4

Add comment about decrypt keys to try

0f76509

Co-authored-by: mix irving <[email protected]>

Use sets for processedNewAuthors

658aebd

Use scuttle.group instead of ssb.tribes

561047a

Elaborate test persistence comment

51dc0d0

Co-authored-by: mix irving <[email protected]>

Fix invite test reattempts

5fc9298

Merge branch 'keyring-no-members' of github.com:ssbc/ssb-tribes into …

48d64ca

…keyring-no-members

Remove persistence comment moved to issue

5d555c1

Refactor processAuthors internal helper

1064aa3

Adapt closing test to windows

a96b41a

Remove a registerAuthors call

f58ed17

Remove another registerAuthors call

c188a7a

Keep unbox test async

d436edf

Merge remote-tracking branch 'origin/keyring-no-members' into exclude

0e12fc2

Powersource changed the base branch from master to keyring-no-members September 5, 2023 14:13

Update package lock

7dd5273

Run CI on branched branches

3d86c30

Powersource mentioned this pull request Sep 8, 2023

Allow being added back into a group after exclusion #79

Open

mixmix force-pushed the keyring-no-members branch from 7903304 to f078721 Compare September 13, 2023 05:00

Base automatically changed from keyring-no-members to master September 18, 2023 04:53

mixmix mentioned this pull request Sep 18, 2023

Squashed: Add publishing of message type for exclusion of members #83

Merged

mixmix closed this Sep 18, 2023

Powersource mentioned this pull request Sep 18, 2023

Exclusion #85

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add publishing of message type for exclusion of members #72

Add publishing of message type for exclusion of members #72

Powersource commented Jul 21, 2023 •

edited

Loading

Powersource commented Jul 21, 2023

Powersource commented Jul 21, 2023

Powersource Jul 23, 2023

Powersource Jul 23, 2023

mixmix Aug 13, 2023

Powersource Aug 17, 2023

Powersource Aug 17, 2023

Powersource Aug 17, 2023

Powersource Jul 23, 2023

Powersource Jul 23, 2023

Powersource Jul 23, 2023

mixmix Aug 13, 2023

Powersource Aug 17, 2023

Powersource commented Jul 25, 2023

Powersource commented Jul 25, 2023

mixmix left a comment

mixmix Aug 13, 2023

Powersource Aug 17, 2023

mixmix Aug 13, 2023

Powersource Aug 17, 2023

mixmix Aug 13, 2023

Powersource Aug 17, 2023

mixmix Aug 13, 2023

Powersource Aug 17, 2023

mixmix Aug 13, 2023

mixmix Aug 13, 2023

Powersource commented Aug 16, 2023

Powersource commented Sep 5, 2023

socket-security bot commented Sep 5, 2023

mixmix commented Sep 18, 2023

Powersource commented Sep 18, 2023

	await p(replicate)({ from: kaitiaki, to: newPerson, live: false, name })
	await p(replicate)({ from: kaitiaki, to: newPerson, live: false })

Add publishing of message type for exclusion of members #72

Add publishing of message type for exclusion of members #72

Conversation

Powersource commented Jul 21, 2023 • edited Loading

Powersource commented Jul 21, 2023

Powersource commented Jul 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Powersource commented Jul 25, 2023

Powersource commented Jul 25, 2023

mixmix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Powersource commented Aug 16, 2023

Powersource commented Sep 5, 2023

socket-security bot commented Sep 5, 2023

mixmix commented Sep 18, 2023

Powersource commented Sep 18, 2023

Powersource commented Jul 21, 2023 •

edited

Loading