Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Multiple format document upload #110

Merged
merged 5 commits into from
Mar 15, 2024
Merged

[Enhancement] Multiple format document upload #110

merged 5 commits into from
Mar 15, 2024

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Mar 15, 2024

Overview/Summary

Generalizing document file format/extensions

This PR fixes/adds/changes/removes

This pull request includes the following formats

  • ConfirmNetworkDiagramExists can be uploaded as a .png/.jpeg/.pdf/.vsdx etc.,
  • GlobalAdministratorsUPN as a .txt
  • all other files can be uploaded as a .txt/.docx/.doc

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 requested review from alalvi00 and singhgss as code owners March 15, 2024 13:34
@dutt0 dutt0 linked an issue Mar 15, 2024 that may be closed by this pull request
Document Uploads Should Be Available in Multiple Formats #109
Closed
@dutt0 dutt0 merged commit 3f204ad into main Mar 15, 2024
4 checks passed
@dutt0 dutt0 deleted the idutta/use_other_attestation_file_extension branch March 15, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhgss singhgss singhgss approved these changes

@alalvi00 alalvi00 alalvi00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Uploads Should Be Available in Multiple Formats
3 participants
@dutt0 @alalvi00 @singhgss