Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] GR12 marketplace logic update #112

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Mar 21, 2024

Overview/Summary

The control looks at the creation and enablement of the Private Marketplace .

This PR fixes/adds/changes/removes

This PR changes the logic and includes the following Comments:

  • If compliant, "The Private Marketplace has been created and enabled."
  • If non compliant, "The Private Marketplace has been created but not enabled."
  • If non compliant "The Private Marketplace has not been created."

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 requested review from alalvi00 and singhgss as code owners March 21, 2024 14:28
@dutt0 dutt0 linked an issue Mar 21, 2024 that may be closed by this pull request
@dutt0 dutt0 requested a review from amrinderssc March 21, 2024 14:34
Copy link
Contributor

@amrinderssc amrinderssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I added GR-ComplianceChecks.zip and Check-PrivateMarketPlace.zip modules to the lab environment.
  2. Disabled the marketplace, and got a non-compliant with the appropriate message
  3. Enabled the marketplace, and got a compliant message "The Private Marketplace has been created and enabled"
  4. No noticeable errors during the module import or main runbook execution

Approved

@dutt0 dutt0 merged commit f57a5de into main Mar 21, 2024
4 checks passed
@dutt0 dutt0 deleted the idutta/marketplace_logic_update branch March 21, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guardrail 12: MarketPlaceCreation (M) Missing Check for Enablement
3 participants