Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Control] GR11 V4 Service Health Alerts and Events Check #289

Merged
merged 14 commits into from
Dec 4, 2024

Conversation

alalvi00
Copy link
Contributor

@alalvi00 alalvi00 commented Dec 3, 2024

Overview/Summary

Developed a new control under Guardrail 11 (GR11) to validate the configuration of Service Health Alerts across all subscriptions. This control ensures that:

  • Required Event Types: The alerts cover critical event types, including Service Issues, Health Advisories, and Security Advisories.

  • Action Group Configuration: Each alert has an associated action group configured to send notifications to at least two distinct email addresses or sub-owners to ensure timely communication of service health events.

This control enhances proactive monitoring and ensures adherence to organizational incident management policies.

This PR fixes/adds/changes/removes

  1. Check-ServiceHealthAlerts.psm1 file added
  2. Check-ServiceHealthAlerts.psd1 file added
  3. GR-ComplianceChecks-Msgs.psd1 changed
  4. GR-ComplianceChecks-Msgs.psd1 (fr-CA) changed
  5. automationaccount.bicep got a new module added
  6. Two zipped modules for new/changed modules added

Breaking Changes

N/A

Testing Evidence

When subscriptions don't have any service health alerts
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@alalvi00 alalvi00 linked an issue Dec 3, 2024 that may be closed by this pull request
@alalvi00 alalvi00 changed the title [New Control] Service Health Alerts and Events Check [New Control] GR11 V4 Service Health Alerts and Events Check Dec 4, 2024
Copy link
Contributor

@dutt0 dutt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alalvi00 alalvi00 merged commit b8328d5 into main Dec 4, 2024
4 checks passed
@alalvi00 alalvi00 deleted the ServiceAlerts-aalvi branch December 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GR11 | Validation 4 | Contact Details for Alerts and Events Checks
3 participants