Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] GR1 V6 and GR7 V3 Added appropriate messaging for uploaded file with incorrect extension and a few misc. update #309

Merged
merged 19 commits into from
Dec 13, 2024

Conversation

dutt0
Copy link
Contributor

@dutt0 dutt0 commented Dec 12, 2024

Overview/Summary

This pull request determines if its a file extension error and provide the appropriate message for clients to consider the file type may be causing the error rather than the filename or not being uploaded

This PR fixes/adds/changes/removes

This Pull Request

  • adds a new message for GR1V6 and GR7V3 when file is uploaded with appropriate file name but with wrong extension.
  • updates the bug report and enhancement template (includes version tag etc.)
  • uses list variable for the role names which can be customized in one go (Reference context SCRv2.1.2 number 8, December2024)
  • removes debug code ((Reference context SCRv2.1.2 number 4, December2024)

Breaking Changes

n/a

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

@dutt0 dutt0 changed the title Idutta/gr1 v6 gr7 v3 file extension [Fix] GR1 V6 and GR7 V3 Added appropriate messaging for uploaded file with incorrect extension Dec 12, 2024
@dutt0 dutt0 marked this pull request as ready for review December 13, 2024 14:36
@dutt0 dutt0 changed the title [Fix] GR1 V6 and GR7 V3 Added appropriate messaging for uploaded file with incorrect extension [Fix] GR1 V6 and GR7 V3 Added appropriate messaging for uploaded file with incorrect extension and a few misc. update Dec 13, 2024
@dutt0 dutt0 merged commit 08508ce into main Dec 13, 2024
4 checks passed
@dutt0 dutt0 deleted the idutta/GR1V6_GR7V3_file_extension branch December 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GR1 V6 and GR7 V3 Missing/Incorrect Comment for Wrong File Type Extension |
3 participants