Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Disable timezone module due to required priviledged access for VMs #321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

singhgss
Copy link
Contributor

Overview/Summary

Check-TimeZoneConsistency requires Microsoft.Compute/virtualMachines/runCommand/action for githhubpipeline service principal which allows it to execute shell or cmd inside linux or windows vm. This is a privilege escalation and will not be taken lightly by our clients as they will not be happy with allowing our guardrail identity do this much and it also goes against Least Privilege access rule

This PR fixes/adds/changes/removes

We disable Check-TimeZoneConsistency module for now

Breaking Changes

None

Testing Evidence

N/A

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant