Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] - Handle scenarios when VNETNAME_s column doesn't exist in Compliance table #68

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

singhgss
Copy link
Contributor

@singhgss singhgss commented Jan 9, 2024

Overview/Summary

In scenarios where no VNET exists or all VNETs are excluded, VNETNAME_s understandably doesn't exist.
The workbook query should handle such cases.
closes #12

This PR fixes/adds/changes/removes

  1. Projects 'VNet Name' as empty string when column VNETNAME_s doesn't exist.

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Ensure PowerShell module versions have been updated (manually or with the ./tools/Update-ModuleVersions.ps1 script)

Copy link
Contributor

@alalvi00 alalvi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good looks

@singhgss singhgss merged commit 67133ef into main Jan 9, 2024
4 checks passed
@singhgss singhgss deleted the gsingh/fix-vNetName-Scalar-expression-error branch January 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Handling: GR9 errors in the workbook if no VNets are part of the tenant v1.1.8
3 participants