Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqs-consumer and sqs-producer to fix graceful shutdown #83

Merged

Conversation

eduardoazevedo3
Copy link
Contributor

Processes in progress are being interrupted before being completed by the Kubernetes deployment or downscale process.

The SQS Consumer and SQS Producer libs already correct this problem. When .stop() is invoked, these libs are already programmed to wait for ongoing processes to finish.

@ssut ssut merged commit 956d052 into ssut:master Jul 12, 2024
@ssut
Copy link
Owner

ssut commented Jul 12, 2024

I'm sorry for the very late response. I've now merged this PR and I really appreciate your contribution. This will be included in the next major release, which will drop support for Node.js v16.

@cpt-pete
Copy link

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

@ssut
Copy link
Owner

ssut commented Jul 12, 2024

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

Thanks for letting me know. I’ll update it very soon, nearly right after my current work.

@ssut
Copy link
Owner

ssut commented Jul 12, 2024

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

FYI: I'm preparing the next release in #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants