Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for long int in class Value. #95

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

olivier-stasse
Copy link
Member

Add support for long int.

Add support for long int.
@olivier-stasse olivier-stasse changed the title Add support for long int in value. Add support for long int in class Value. Jan 7, 2022
…g of None as void.

While here fix the exception message for int (remove the second int).
Fix the test accordingly.
@MaximilienNaveau MaximilienNaveau self-requested a review January 10, 2022 07:56
Copy link

@MaximilienNaveau MaximilienNaveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
the code itself is good we can merge this PR.

I however do not understand the need of it as now you can create command with boost-python directly and hence have access to virtually any function signature.
Hence the need of such development is minimal, or I am missing something...

You can still merge the request. It seems a good idea to be able to share long int through commands.

@MaximilienNaveau MaximilienNaveau added the Feature Adding a feature to the repository label Jan 10, 2022
@MaximilienNaveau MaximilienNaveau linked an issue Jan 10, 2022 that may be closed by this pull request
@olivier-stasse
Copy link
Member Author

olivier-stasse commented Jan 10, 2022

Hi, the code itself is good we can merge this PR.

I however do not understand the need of it as now you can create command with boost-python directly and hence have access to virtually any function signature. Hence the need of such development is minimal, or I am missing something...

You can still merge the request. It seems a good idea to be able to share long int through commands.

I agree.
For now let us say this is mostly to maintain existing code using command.
The current problem is that many compiling warnings are popping up because not all types are available through the Value interface.

@olivier-stasse
Copy link
Member Author

One note: people used to command appreciate the fact that they do not have to do the python bindings.
If we bind other language and use an equivalent system, then this would be handy.

@MaximilienNaveau
Copy link

Agreed, good point!

@olivier-stasse olivier-stasse merged commit b852eef into stack-of-tasks:devel Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Adding a feature to the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants