Add role to deploy cASO

[jovial]

cASO is an OpenStack accounting extractor. For more detail see:
https://github.com/IFCA/caso

By default, cASO is configured to output to Fluentd via TCP. The
accounting information can then be shipped off to ElasticSearch.

(cherry picked from commit d8ab00f)
(cherry picked from commit 67ee60e)
Change-Id: Ib81ec443bbb14d494d7c81dff617b371a1b68c52

[jovial]

I've updated this following Mark's review comments in: #160

[markgoddard]

Are you sure these should be raw?

[jovial]

Hmm, good point. This does look wrong, I just copied this across from the original patch.

[jovial]

The bizaare thing is that this works as is:

<match apel.events>
    @type copy
    <store>
       @type elasticsearch
       host 192.168.33.2
       port 9200
       logstash_format true
       logstash_prefix apel
       flush_interval 15s
       reload_connections false
       reconnect_on_error true
    </store>
</match>

[jovial]

This is without:

<match apel.events>
    @type copy
    <store>
       @type elasticsearch
       host 192.168.33.2
       port 9200
       logstash_format true
       logstash_prefix apel
       flush_interval 15s
       reload_connections false
       reconnect_on_error true
    </store>
</match>

I'll remove it anyway for neatness.

[jovial]

Done

[priteau]

I guess it will fail if the inventory is missing the caso group?

[priteau]

If this was an upstream patch I would point out the lack of extra_volumes support, but this could be merged without it.

[jovial]

I guess it will fail if the inventory is missing the caso group?

Good point. I think I just need to add stuff like:

groups['caso'] | default([])

to any of the tasks outside of the caso role.

[priteau]

I guess it will fail if the inventory is missing the caso group?

Good point. I think I just need to add stuff like:

groups['caso'] | default([])

to any of the tasks outside of the caso role.

You can check how it was done for the libvirt-exporter change on Xena:

• https://review.opendev.org/c/openstack/kolla-ansible/+/831850
• https://review.opendev.org/c/openstack/kolla-ansible/+/833167
• https://review.opendev.org/c/openstack/kolla-ansible/+/834620

[markgoddard]

I guess it will fail if the inventory is missing the caso group?

Good point. I think I just need to add stuff like:

groups['caso'] | default([])

to any of the tasks outside of the caso role.

You can check how it was done for the libvirt-exporter change on Xena:

• https://review.opendev.org/c/openstack/kolla-ansible/+/831850
• https://review.opendev.org/c/openstack/kolla-ansible/+/833167
• https://review.opendev.org/c/openstack/kolla-ansible/+/834620

Wouldn't we never get there, since the play would not match in site.yml?

[priteau]

I guess it will fail if the inventory is missing the caso group?

Good point. I think I just need to add stuff like:

groups['caso'] | default([])

to any of the tasks outside of the caso role.

You can check how it was done for the libvirt-exporter change on Xena:

• https://review.opendev.org/c/openstack/kolla-ansible/+/831850
• https://review.opendev.org/c/openstack/kolla-ansible/+/833167
• https://review.opendev.org/c/openstack/kolla-ansible/+/834620

Wouldn't we never get there, since the play would not match in site.yml?

Good point, it's a new role rather than an extension of an existing one.

[jovial]

I guess it will fail if the inventory is missing the caso group?

Good point. I think I just need to add stuff like:

groups['caso'] | default([])

to any of the tasks outside of the caso role.

You can check how it was done for the libvirt-exporter change on Xena:

• https://review.opendev.org/c/openstack/kolla-ansible/+/831850
• https://review.opendev.org/c/openstack/kolla-ansible/+/833167
• https://review.opendev.org/c/openstack/kolla-ansible/+/834620

Wouldn't we never get there, since the play would not match in site.yml?

I think this would fail though: https://github.com/stackhpc/kolla-ansible/pull/205/files#diff-d33e12c3e3423adcb3eca3138dbc35ff4a5c224a307f38d088fce52a1ca9b56aR77

as it is outside the role?

Edit: confirmed an issue here:

TASK [common : Copying over td-agent.conf] **********************************************************************************************************************************
fatal: [controller0]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'caso'"}

Edit2: forgot to not set enable_caso.

[jovial]

I've removed the unnecessary raw tags and confirmed that a missing caso group doesn't break any tasks (provided that you do not set enable_caso: true.