Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/674070 tfp | cleanup logic for old ske credentials rotation flow #611

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Feat/674070 tfp | cleanup logic for old ske credentials rotation flow #611

merged 5 commits into from
Dec 19, 2024

Conversation

bahkauv70
Copy link
Contributor

@bahkauv70 bahkauv70 commented Dec 12, 2024 •
edited
Loading

PR to address issue #534
This removes references to the read-only kube_config attribute in the cluster definition

@bahkauv70 bahkauv70 force-pushed the feat/674070-TFP-|-Cleanup-logic-for-old-SKE-credentials-rotation-flow branch from aac5dc5 to b8a4e1b Compare December 12, 2024 10:47
@vicentepinto98
Copy link
Contributor

Also check the acceptance test in ske_acc_test.go and remove the places where kube_config is referenced

@vicentepinto98
Copy link
Contributor

Pull from main and re-generate docs, there are unrelated changes currently

@bahkauv70 bahkauv70 force-pushed the feat/674070-TFP-|-Cleanup-logic-for-old-SKE-credentials-rotation-flow branch 2 times, most recently from 85a7757 to 9c4007b Compare December 13, 2024 08:50
@bahkauv70 bahkauv70 marked this pull request as ready for review December 13, 2024 08:51
@bahkauv70 bahkauv70 force-pushed the feat/674070-TFP-|-Cleanup-logic-for-old-SKE-credentials-rotation-flow branch from 9c4007b to f97009b Compare December 13, 2024 08:54
vicentepinto98
vicentepinto98 reviewed Dec 16, 2024
View reviewed changes
docs/data-sources/resourcemanager_project.md Outdated Show resolved Hide resolved
docs/resources/key_pair.md Show resolved Hide resolved
docs/resources/server.md Show resolved Hide resolved
docs/resources/resourcemanager_project.md Outdated Show resolved Hide resolved
@bahkauv70 bahkauv70 self-assigned this Dec 17, 2024
@bahkauv70 bahkauv70 force-pushed the feat/674070-TFP-|-Cleanup-logic-for-old-SKE-credentials-rotation-flow branch from f97009b to 67e149b Compare December 17, 2024 12:54
@bahkauv70 bahkauv70 force-pushed the feat/674070-TFP-|-Cleanup-logic-for-old-SKE-credentials-rotation-flow branch from a3bb48d to 32fd849 Compare December 18, 2024 10:43
@bahkauv70 bahkauv70 merged commit a297043 into main Dec 19, 2024
3 checks passed
@bahkauv70 bahkauv70 deleted the feat/674070-TFP-|-Cleanup-logic-for-old-SKE-credentials-rotation-flow branch December 19, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentepinto98 vicentepinto98 vicentepinto98 approved these changes

Assignees

@bahkauv70 bahkauv70

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahkauv70 @vicentepinto98