ROX-27352: Set automerge schedule to create branches at quiet time #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renovate automerging started happening after #18.
I thought we need to additionally configure StackRox, Collector and Scanner repos to update our
quay.io/rhacs-eng/konflux-tasksimage but this seems to be happening without any extra config. Yay!See stackrox/stackrox#13493 and stackrox/collector#2003.
What remains in the scope of https://issues.redhat.com/browse/ROX-27352 is to calm down Renovate to not send changes during our working hours.
In this change I simply restore the same
after 3am and before 7amexpression we use in other repos. I don't know yet whether it would be too frequent or ok.Note that this schedule configures the time when Renovate will create new branches or refresh existing ones. In order to additionally limit the time when Renovate merges them, we could use the automergeSchedule setting. At this point, I don't see a case for us to limit that assuming that the pipeline should execute quickly enough. I suggest that we leave it out for now but have in mind for the future.
There's an obvious downside of having Renovate making and merging changes automatically - potential merge conflicts if an engineer makes a change to the step
imageor to tasks in the build pipeline in their PR. This is unavoidable and the only way to limit the impact is by reducing the frequency through the schedule. Again, let's start with this schedule and see if the conflicts become bothering, then we can reduce it.Testing
None. Just ran a validator.
Will observe Renovate commits for a few days after this change gets merged.