Setup blocklist client template #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djordon
reviewed
May 2, 2024
|
I assume this closes #76, I'll link this issue with the PR. For future PRs, I recommend creating the branch from the issue itself because then you'll get both a canonical branch name and automatic linking once you open up a PR.
|
netrome
reviewed
May 2, 2024
added 5 commits
May 2, 2024 14:19
netrome
approved these changes
May 3, 2024
Comment on lines
+1
to
+2
| use crate::config::Settings; | ||
| use ::config::{Config, File}; |
There was a problem hiding this comment.
Isn't these both the same import? I think we should be explicit and go with crate::config for both, and avoid relative imports.
There was a problem hiding this comment.
First one is for the config.rs at root level. Second one is from a lib.
That's what the auto-import gives and for some reason it's not happy when I don't use :: for the second one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic setup for blocklist client using warp framework.
Closes #76
Testing information
Verified the local server but the exposed route is not integrated with a provider yet so testing will be done in subsequent commits.