Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add attachments handler to the sidecar #1107

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

Jiloc
Copy link
Collaborator

@Jiloc Jiloc commented Dec 12, 2024

Description

As detailed in stacks-core issue #5558, we discovered that when connected to a syncing stacks-node, the node rarely sends POST requests to the configured event observers at the /attachments/new endpoint - even if the events observer is configured to filter only specific events.

This issue was observed during a sync starting from the genesis block, though it is unclear whether it also occurs with more recent messages.

Changes

  • added dummy handler for /attachments/new

Testing Information

  • add unit tests to confirm that the enpoint always returns 200 whatever the input

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Jiloc Jiloc added this to the sBTC 0.9, mainnet release milestone Dec 12, 2024
@Jiloc Jiloc self-assigned this Dec 12, 2024
@Jiloc Jiloc merged commit 57c30e4 into main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants