Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Dockerfile we are using in CI prevented the
build.rs
file from getting the currentgit_commit
, which was resulting in an empty revision (e.g. in metrics, this was also breaking Cloudwatch collection).(For context, this took me longer than I expected because the code did not check the result of
git rev-parse
and would produce an empty string on failure).This fixes it.
Before merging, please that the build resulting from this manual run embeds the correct revision.