feat: Signer message type definition #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
djordon
approved these changes
May 6, 2024
Comment on lines
+16
to
+25
| pub enum Payload { | ||
| SignerDepositDecision(SignerDepositDecision), | ||
| SignerWithdrawDecision(SignerWithdrawDecision), | ||
| StacksTransactionSignRequest(StacksTransactionSignRequest), | ||
| StacksTransactionSignature(StacksTransactionSignature), | ||
| BitcoinTransactionSignRequest(BitcoinTransactionSignRequest), | ||
| BitcoinTransactionSignAck(BitcoinTransactionSignAck), | ||
| /// Contains all variants for DKG and WSTS signing rounds | ||
| WstsMessage(wsts::net::Message), | ||
| } |
There was a problem hiding this comment.
Is this so that we can deserialize responses into one thing?
There was a problem hiding this comment.
Not sure I understand the question, but if you're wondering why I've chosen to represent the payload as an enum it's just to be able to represent all different types of payloads within the single SignerMessage struct.
8marz8
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #104
This PR introduces the base message type according to the signer communication LLD, and paves the way for future work on the signer message variants and network.