getContext feature implementation (similar to TraceKit context field) #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new method
getContext
is implemented. The method gets the surrounding source code for where exception occurs. Similar to TraceKit context, but much more clever and flexible.I've seen 3 ways to implement this:
context
field to thestackframe
class.getContext
method to thestacktrace-gps
, which returns a separate object with the context source code.I've decided to go the 3rd way, but if the stacktracejs team thinks, it should be done other way, just let me know.
Motivation and Context
It's very standard feature for all the error tracking tools, to show the surrounding source code (badly named "context") where the error occurs.
I've spent many hours fighting and hacking the TraceKit implementation (main problems: hard to configure the limits, very big and useless results for uglified code, inability to find out the line number of the code).
How Has This Been Tested?
Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc stacktrace-gps.js
passes without errorsnpm test
passes without errors