Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getContext feature implementation (similar to TraceKit context field) #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ximik
Copy link

@Ximik Ximik commented Jul 6, 2020

Description

A new method getContext is implemented. The method gets the surrounding source code for where exception occurs. Similar to TraceKit context, but much more clever and flexible.

I've seen 3 ways to implement this:

  1. Create additional package.
  2. Add the context field to the stackframe class.
  3. Add the getContext method to the stacktrace-gps, which returns a separate object with the context source code.

I've decided to go the 3rd way, but if the stacktracejs team thinks, it should be done other way, just let me know.

Motivation and Context

It's very standard feature for all the error tracking tools, to show the surrounding source code (badly named "context") where the error occurs.
I've spent many hours fighting and hacking the TraceKit implementation (main problems: hard to configure the limits, very big and useless results for uglified code, inability to find out the line number of the code).

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • node_modules/.bin/jscs -c .jscsrc stacktrace-gps.js passes without errors
  • npm test passes without errors
  • I have read the contribution guidelines
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant