Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --use-driver option to fix the GDAL driver to be used #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

constantinius
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple smoke-test? E.g. (untested test):

def test_use_driver():
    runner = CliRunner()
    result = runner.invoke(command, ["datacube", "create-item", "--use-driver", "ZARR", "tests/data-files/tiny-zarr/", str(tmp_path) / "out.json"]
    assert result.status_code == 0

tests/test_stac.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI needs fixin'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants