Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vue 3 and the Composition API #6

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Upgrade to Vue 3 and the Composition API #6

wants to merge 14 commits into from

Conversation

rydurham
Copy link
Member

This PR upgrades this project to be compatible with Vue 3. There are some notable changes:

  • We are now using Three.js directly instead of the Three-Full wrapper package.
  • We are using the Vue 3 composition API and component <script setup> wherever possible.
  • Based on @Camil88's research most of the Three.js elements are added to the store with the markRaw helper. This is a recommended best practice for storing non-reactive elements in state. Eliminating reactivity where it is not needed should help lower overall memory usage and improve performance.
  • Rather than upgrade to the latest version of Vuex this PR uses Pinia for state management, which is the new preference in the Vue community.
  • HMR has been disabled; I have noticed some memory issues that seem to be aggravated by HMR. This may require further investigation. In theory this should not impact an application in production.
  • I have included a docker setup for those who are interested - this is optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant