Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed(BluePrint): Edit Form Overflows Screen on Delete Button Click #1688

Closed
wants to merge 3 commits into from
Closed

Fixed(BluePrint): Edit Form Overflows Screen on Delete Button Click #1688

wants to merge 3 commits into from

Conversation

sophieturner0
Copy link
Contributor

@sophieturner0 sophieturner0 commented Jun 18, 2024 •
edited
Loading

Problem:

  • When the Delete button is clicked within the Edit Form, the form overflows the bottom boundaries of the screen.

closes: #1681

Issue ticket number and link:

Evidence:

  • Please see the attached video as evidence.

https://www.loom.com/share/7bb2dae28ee84bd7bffaeae8c42028dc

image

Acceptance Criteria

  • When the Delete button is clicked, the Edit Form should remain within the boundaries of the modal window, ensuring all form elements are visible and accessible without overflow.

@sophieturner0
Copy link
Contributor Author

Hi @Rassl,
Please review this PR.

Rassl
Rassl reviewed Jun 24, 2024
View reviewed changes
...mponents/ModalsContainer/BlueprintModal/Body/Editor/CustomAttributesStep/FormInput/index.tsx Outdated
@@ -155,5 +155,5 @@ export const FormInput = ({
const InputsWrapper = styled(Flex)`
overflow-y: auto;
width: calc(100% + 20px);
max-height: calc(80vh - 300px);
max-height: 230px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 230? can we make it responsive instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rassl, I try?

@sophieturner0
Copy link
Contributor Author

sophieturner0 commented Jul 23, 2024 •
edited
Loading

Hi @Rassl, Please review this PR.

New changes results:

Big screen:
image

small screen:
image

@sophieturner0 sophieturner0 requested a review from Rassl July 23, 2024 22:27
@sophieturner0
Copy link
Contributor Author

Hi @Rassl, Please review this PR.

@Rassl Rassl closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Awaiting requested review from Rassl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Bug: Edit Form Overflows Screen on Delete Button Click
2 participants
@sophieturner0 @Rassl