Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FilterSearch]: Modal closes after clicking Show Result button, but the cross (X) icon remains visible #2137

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

saithsab877
Copy link
Contributor

Problem:

  • When the Show Result button is clicked in the FilterSearch modal, the modal closes as expected, but the cross (X) icon remains visible on the screen.

closes: #2136

Issue ticket number and link:

Evidence:

https://www.loom.com/share/f2f00d826b4d4f258b2a476cd95faf74

Acceptance Criteria

  • After clicking the "Show Result" button, the modal closes and the cross (X) icon should disappear.

@saithsab877
Copy link
Contributor Author

Hi @Rassl, Please review this PR.

@saithsab877 saithsab877 force-pushed the filtersearch-modal-close-icon branch 2 times, most recently from cae96b7 to 535c175 Compare September 15, 2024 11:08
@Rassl Rassl merged commit cca8ef7 into stakwork:master Sep 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FilterSearch]: Modal closes after clicking Show Result button, but the cross (X) icon remains visible
2 participants