Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SideBarView]: Search Text Clears When Side Panel is Collapsed #2197

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

sophieturner0
Copy link
Contributor

Problem:

  • When entering text into the search field and subsequently clicking to collapse the side panel, the search text is unexpectedly cleared from the search field.

closes: #2196

Issue ticket number and link:

Evidence:

  • Please see the attached video as evidence.

https://www.loom.com/share/6d9325c3a99548a19f7f667abb00f2df

Acceptance Criteria

  • The search text should remain in the search field when the side panel is collapsed.

@sophieturner0
Copy link
Contributor Author

Hi @Rassl, Please review this PR.

@Rassl
Copy link
Collaborator

Rassl commented Oct 17, 2024

what is the reason it get cleared? Just resetting same value is not good solution

@sophieturner0
Copy link
Contributor Author

Hi @Rassl, Please review demo with new changes :

https://www.loom.com/share/a737a678bf784395943264d5fdbf07c4

@sophieturner0
Copy link
Contributor Author

Hi @Rassl, Please review this PR.

@Rassl Rassl merged commit e44e8a6 into stakwork:master Nov 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SideBarView]: Search Text Clears When Side Panel is Collapsed
2 participants