Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLDR Background Allows Clicks Behind Modals #2330

Merged
merged 2 commits into from
Nov 1, 2024
Merged

TLDR Background Allows Clicks Behind Modals #2330

merged 2 commits into from
Nov 1, 2024

Conversation

saithsab877
Copy link
Contributor

@saithsab877 saithsab877 commented Oct 9, 2024 •
edited
Loading

Problem:

  • When the TLDR modal is open, the background is clickable, allowing interactions with elements behind the modal.

closes: #2269

Issue ticket number and link:

Evidence:

https://www.loom.com/share/75dd2d8bd2c245c5860a63e0c57db7b4

image

Acceptance Criteria

  • The behind modals should not be clickable when the TLDR modal is open.

@saithsab877
Copy link
Contributor Author

Hi @Rassl, @tomsmith8, Please review this PR.

@saithsab877 saithsab877 changed the title TLDR Background Allows Clicks Behind Modals and Stats Bar TLDR Background Allows Clicks Behind Modals Oct 17, 2024
@Rassl Rassl merged commit cc97eb6 into stakwork:master Nov 1, 2024
17 checks passed
@Rassl Rassl mentioned this pull request Nov 1, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Rassl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HomePage]: TLDR Background Allows Clicks Behind Modals and Stats Bar
2 participants
@saithsab877 @Rassl