Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BluePrint]: Add Close Button Functionality to Color Modal #2362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BluePrint]: Add Close Button Functionality to Color Modal #2362

wants to merge 1 commit into from
+29 −4

Conversation

Shoaibdev7
Copy link
Contributor

Problem:

  • We should probably add a close button to ensure we can at least close if the original button is hidden.

Evidence:

image

https://www.loom.com/share/861c1fac6d2c4945849993ccaa13f859

Acceptance Criteria

  • Add a functional close button to the Color Modal for improved accessibility.

@Shoaibdev7
Copy link
Contributor Author

Hi @tomsmith8, @Rassl, Please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Shoaibdev7