Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed[Filter]: Made Filter Buttons Sticky for Enhanced Usability #2419

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Fixed[Filter]: Made Filter Buttons Sticky for Enhanced Usability #2419

merged 4 commits into from
Nov 8, 2024

Conversation

MuhammadUmer44
Copy link
Contributor

Problem:

  • When opening the filter modal, the bottom buttons should be sticky so users don't have to scroll to know they are there:

Issue ticket number and link:

closes: #2414

Evidence:

https://www.loom.com/share/b735cb810b4246acb53b248575ce9e64

image

Acceptance Criteria:

  • Bottom two buttons are always visible
  • Scroll should happen behind the sticky component

@MuhammadUmer44
Copy link
Contributor Author

Hi @Rassl, Please review this PR.

@tomsmith8
Copy link
Contributor

One small addition, could we renamed to Apply

@MuhammadUmer44
Copy link
Contributor Author

One small addition, could we renamed to Apply

Mean Show Results to Apply

@tomsmith8
Copy link
Contributor

Yes please!

@MuhammadUmer44
Copy link
Contributor Author

Yes please!

@tomsmith8 Ok No Problem

@MuhammadUmer44
Copy link
Contributor Author

@tomsmith8, Please see

image

@MuhammadUmer44
Copy link
Contributor Author

One small addition, could we renamed to Apply

@tomsmith8 Done

@Rassl Rassl merged commit 429ba27 into stakwork:master Nov 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Rassl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filters buttons should be sticky
3 participants
@MuhammadUmer44 @tomsmith8 @Rassl