Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph Mindset] Border and Padding #2514

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[Graph Mindset] Border and Padding #2514

merged 1 commit into from
Dec 9, 2024

Conversation

saithsab877
Copy link
Contributor

@saithsab877 saithsab877 commented Dec 9, 2024 •
edited
Loading

Problem:

  • Ensure all borders, paddings, and margins around UI components (transcript card, video player, and timeline) are consistent with the 20px design standard.

closes: #2508

Issue ticket number and link:

Evidence:

image

@saithsab877
Copy link
Contributor Author

Hi @Rassl, @tomsmith8, Please review this PR.

@Rassl Rassl self-requested a review December 9, 2024 09:40
@Rassl Rassl merged commit eba847c into stakwork:master Dec 9, 2024
10 of 17 checks passed
@tomsmith8
Copy link
Contributor

I notice that on the right hand side, the centre button and timeline are not in line. Can we update that?

@tomsmith8
Copy link
Contributor

Actually, maybe they are..

@saithsab877
Copy link
Contributor Author

I notice that on the right hand side, the centre button and timeline are not in line. Can we update that?

@tomsmith8 Sure.

@tomsmith8
Copy link
Contributor

Screenshot 2024-12-09 at 13 36 23

@saithsab877
Copy link
Contributor Author

Screenshot 2024-12-09 at 13 36 23

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rassl Rassl Rassl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Graph Mindset] Border and Padding
3 participants
@saithsab877 @tomsmith8 @Rassl