Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sequenced Nodes View to Sidebar #2560

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

aliraza556
Copy link
Contributor

Ticket №:

closes #ticket_number

Problem:

insert problem you are trying to solve here

Solution:

what was the solution?

Changes:

exactly what changes did you make?

Testing:

did you add any aditional test coverage if so where and what did you test

Notes:

any additional notes

<StyledSequenceWrapper>
{sequencedNodes.map((item, idx) => (
<React.Fragment key={`${item.node.ref_id}-${item.sequence}`}>
<Text>{item.node.properties?.index || item.node.properties?.text}</Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not good, we should get index, get prop name from schemaStore, and assign item.node.properties[keyProp]

Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look to my comment, also attach screenshot

@aliraza556
Copy link
Contributor Author

@Rassl Please review new changes

@Rassl Rassl self-requested a review December 19, 2024 13:33
Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rassl Rassl merged commit 9131b96 into stakwork:master Dec 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants