Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run prettier in github actions #435

Merged
merged 1 commit into from
Nov 4, 2022
Merged

run prettier in github actions #435

merged 1 commit into from
Nov 4, 2022

Conversation

antonilol
Copy link
Contributor

@antonilol antonilol commented Sep 16, 2022 •
edited
Loading

title

draft pr for now because i dont want this merged before #423 (it will be a pain to rebase that pr with many little changes this produces)

@kevkevinpal
Copy link
Contributor

is there anyway of running prettier on the PR itself when someone opens to master so the diff is never ugly incase someone auto formats to prettier with their own config?

@antonilol
Copy link
Contributor Author

is there anyway of running prettier on the PR itself when someone opens to master so the diff is never ugly incase someone auto formats to prettier with their own config?

I tried this with the auto build but it didnt seem to work, even with the "Allow edits from maintainers" setting turned on

@antonilol
Copy link
Contributor Author

antonilol commented Sep 27, 2022 •
edited
Loading

just realized i can run prettier on other prs and merge/rebase should go fine because both branches contain the same change

@antonilol antonilol marked this pull request as ready for review September 27, 2022 21:52
@antonilol
Copy link
Contributor Author

antonilol commented Sep 29, 2022 •
edited
Loading

rebased + also formats .github/**/*.yml now

@antonilol antonilol mentioned this pull request Oct 2, 2022
Closed
@antonilol antonilol force-pushed the ghactions-prettier branch 3 times, most recently from 5cc2f6c to f13d4ad Compare October 4, 2022 19:17
@antonilol
Copy link
Contributor Author

is there anyway of running prettier on the PR itself when someone opens to master so the diff is never ugly incase someone auto formats to prettier with their own config?

it would actually be really annoying to have a script continuously push commits to a development branch when rebasing and merging, etc. i think it would really mess things up

@antonilol
Copy link
Contributor Author

rebased

kevkevinpal
kevkevinpal approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@kevkevinpal kevkevinpal merged commit 42d99a7 into stakwork:master Nov 4, 2022
@antonilol antonilol deleted the ghactions-prettier branch November 5, 2022 12:22
@antonilol antonilol mentioned this pull request Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevkevinpal kevkevinpal kevkevinpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonilol @kevkevinpal