Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto populate Org name for post bounty modal #13

Closed
wants to merge 10 commits into from
Closed

Auto populate Org name for post bounty modal #13

wants to merge 10 commits into from

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Jan 24, 2024

@ecurrencyhodler
Copy link
Contributor

Video looks good. Sorry one more thing. We have reverted our backend api calls from api.people-test->people.test. So we no longer will require the "api" in front of the call.

Can you push another commit? I think that'll trigger our github actions workflows for testing. Also in the future, you can run the tests locally as well using: yarn run.

@ecurrencyhodler
Copy link
Contributor

Looks like you have a conflicting file: src/config/host.ts

@Vayras
Copy link
Contributor Author

Vayras commented Jan 24, 2024

Looks like you have a conflicting file: src/config/host.ts

@ecurrencyhodler fixed , got the workflows running for this one, Implementing for the others

@elraphty
Copy link
Collaborator

@Vayras Your code breaks the Organization Drop down, No organization gets listed Linnk to Loom Video
https://www.loom.com/share/1986741048594198a6e1577e2b68a643

And please remove the commented code block.

@Vayras
Copy link
Contributor Author

Vayras commented Jan 25, 2024

@elraphty well, There are two approaches to this , the original list of organization does not list the bounties Platform, it lists 18 total organization , the code for that is commented for now , I have both the implementations ready at hand ,
here the video showing all the other organization :https://www.loom.com/share/62ef6756679a41c2a690316c6c9e987c

@Vayras
Copy link
Contributor Author

Vayras commented Jan 25, 2024

@ecurrencyhodler @elraphty since Bounty platform was not available , I used this approach to populate it , We can apply whatever works best in this case , let me know your review

@elraphty
Copy link
Collaborator

@elraphty well, There are two approaches to this , the original list of organization does not list the bounties Platform, it lists 18 total organization , the code for that is commented for now , I have both the implementations ready at hand , here the video showing all the other organization :https://www.loom.com/share/62ef6756679a41c2a690316c6c9e987c

I can't see your recording @Vayras it's blurry, But I believe the best solution is reducing the Input abstraction and manipulating the dropdown in that post-bounty modal component.

@Vayras
Copy link
Contributor Author

Vayras commented Jan 29, 2024

@elraphty @ecurrencyhodler I'm closing this PR and Resubmitting it proper functionality

@Vayras Vayras closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants