Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#143: Enable ability to edit org if website or github isn't provided #150

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

VividhPandey003
Copy link
Contributor

@VividhPandey003 VividhPandey003 commented Feb 4, 2024

Describe your changes

fix.mov

Issue ticket number and link

Closes #143

Also tests out 1496 by @Vayras

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@VividhPandey003 VividhPandey003 marked this pull request as draft February 4, 2024 13:53
@Vayras
Copy link
Contributor

Vayras commented Feb 4, 2024

@VividhPandey003 try making the value equal to the expected value that might fix it, also if you can tell me the scope of the testing I can help you further
expect(received).toBeUndefined() Received: "Updated Description".

@VividhPandey003
Copy link
Contributor Author

Oh actually I'm working on it. Thanks for having a look. I'll let you know if I face any issues.
I actually have some more fixes to make right now😅

@ecurrencyhodler
Copy link
Contributor

@VividhPandey003 #1496 has been merged!

@VividhPandey003
Copy link
Contributor Author

@VividhPandey003 #1496 has been merged!

yes I have made the changes. just passing the tests and i'll change the pr from draft to get reviewed

@VividhPandey003 VividhPandey003 marked this pull request as ready for review February 7, 2024 20:03
@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

All checks passed and tested on local, Clear for merging @kevkevinpal

@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

@VividhPandey003 I think after your recent commit Cypress is failing can you take a look?

@VividhPandey003
Copy link
Contributor Author

hmm that is weird.

@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

@kevkevinpal can you check this Cypress Test fail?

@kevkevinpal
Copy link
Collaborator

rebased and squashed your commits to one 14b3c15

@VividhPandey003
Copy link
Contributor Author

rebased and squashed your commits to one 14b3c15

Thanks @kevkevinpal

@kevkevinpal kevkevinpal merged commit 02be1c8 into stakwork:master Feb 7, 2024
5 checks passed
@ecurrencyhodler
Copy link
Contributor

Tested and it works. Good job! Paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable ability to edit org if website or github isn't provided
4 participants