-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented status filter for super admin page #44
Implemented status filter for super admin page #44
Conversation
@ecurrencyhodler Could you please review this PR. |
Eslint and prettier test failed. |
Prettier is still struggling :( |
Hi @AbdulWahab3181
I guess it should show you the exact warnings in the file that is failing src/pages/superadmin/constants.ts
The pre-commit hook runs 'yarn run lint' for you when you are committing. if you have less than or equal to 69 warnings then you are good to go |
I've executed |
@AbdulWahab3181 fix prettier by running |
@elraphty Nothing happens when I run video1676978879.mp4 |
Check pass! Let's get a code review. |
@AbdulWahab3181 same for this one rebase to master and the failing test will be fixed |
880970c
to
5b4c992
Compare
…hab3181/sphinx-tribes-frontend into superadmin-status-filter
…bes-frontend into superadmin-status-filter
@AbdulWahab3181 all checks have passed. I will test the code locally now |
@AbdulWahab3181 Tested on local this works as intended |
@ecurrencyhodler This can be merged once @kevkevinpal approves this and @AbdulWahab3181 can maybe squash their commits for this |
@kevkevinpal @Vayras I have created this PR #196 to prevent squashing commits, as the current PR is too old and has a lot of changes. It's really difficult to resolve multiple conflicts on multiple files without knowledge of others' work. Please review and merge this PR #196 and close the current one |
Describe your changes
video1280801786.mp4
Issue ticket number and link
Closes #187
Type of change
Please delete options that are not relevant.
Checklist before requesting a review