Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented status filter for super admin page #44

Closed

Conversation

AbdulWahab3181
Copy link
Contributor

@AbdulWahab3181 AbdulWahab3181 commented Jan 26, 2024

Describe your changes

video1280801786.mp4

Issue ticket number and link

Closes #187

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@AbdulWahab3181
Copy link
Contributor Author

@ecurrencyhodler Could you please review this PR.

@ecurrencyhodler
Copy link
Contributor

Eslint and prettier test failed.

@ecurrencyhodler
Copy link
Contributor

Prettier is still struggling :(

@AbdulWahab3181
Copy link
Contributor Author

Prettier is still struggling :(

I am not sure why it's causing a problem. It's working fine locally. Could you please rerun the failed job?

image

@Ekep-Obasi
Copy link
Contributor

Ekep-Obasi commented Jan 28, 2024

Hi @AbdulWahab3181
Run

'yarn run lint'
Please make sure that you don't have more than 69 warnings.

I guess it should show you the exact warnings in the file that is failing src/pages/superadmin/constants.ts

'yarn run lint:fix'
should fix the error

The pre-commit hook runs 'yarn run lint' for you when you are committing. if you have less than or equal to 69 warnings then you are good to go

@AbdulWahab3181
Copy link
Contributor Author

Hi @AbdulWahab3181 Run

'yarn run lint'
Please make sure that you don't have more than 69 warnings.

I guess it should show you the exact warnings in the file that is failing src/pages/superadmin/constants.ts

'yarn run lint:fix'
should fix the error

The pre-commit hook runs 'yarn run lint' for you when you are committing. if you have less than or equal to 69 warnings then you are good to go

I've executed yarn run lint, and it reported less than 69 warnings. And there is no warnings in the file that is failing src/pages/superadmin/constants.ts.

image

@elraphty
Copy link
Collaborator

@AbdulWahab3181 fix prettier by running yarn run pretter

@AbdulWahab3181
Copy link
Contributor Author

AbdulWahab3181 commented Jan 29, 2024

@AbdulWahab3181 fix prettier by running yarn run pretter

@elraphty Nothing happens when I run yarn run prettier, as you can see in the attached video.

video1676978879.mp4

@ecurrencyhodler
Copy link
Contributor

Check pass! Let's get a code review.

@Vayras
Copy link
Contributor

Vayras commented Feb 3, 2024

@AbdulWahab3181 same for this one rebase to master and the failing test will be fixed

@AbdulWahab3181 AbdulWahab3181 force-pushed the superadmin-status-filter branch from 880970c to 5b4c992 Compare February 7, 2024 06:29
@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

@AbdulWahab3181 all checks have passed. I will test the code locally now

@ecurrencyhodler ecurrencyhodler removed this from the Superadmin milestone Feb 7, 2024
@Vayras
Copy link
Contributor

Vayras commented Feb 8, 2024

@AbdulWahab3181 Tested on local this works as intended

@Vayras
Copy link
Contributor

Vayras commented Feb 8, 2024

@ecurrencyhodler This can be merged once @kevkevinpal approves this and @AbdulWahab3181 can maybe squash their commits for this

@AbdulWahab3181
Copy link
Contributor Author

@ecurrencyhodler This can be merged once @kevkevinpal approves this and @AbdulWahab3181 can maybe squash their commits for this

@kevkevinpal @Vayras I have created this PR #196 to prevent squashing commits, as the current PR is too old and has a lot of changes. It's really difficult to resolve multiple conflicts on multiple files without knowledge of others' work. Please review and merge this PR #196 and close the current one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "status" filter on the bottom half of the dashboard
5 participants