Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/setup cypress #45

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Feat/setup cypress #45

merged 8 commits into from
Jan 31, 2024

Conversation

tobi-bams
Copy link
Collaborator

@tobi-bams tobi-bams commented Jan 27, 2024

Describe your changes

Set up Cypress

Issue ticket number and link

#19 and #20

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@tobi-bams
Copy link
Collaborator Author

Uploading Screen Recording 2024-01-27 at 01.23.11.mov…

@ecurrencyhodler here is a screen recording of the test flow on my local machine

@ecurrencyhodler
Copy link
Contributor

Ooo @tobi-bams it looks like the video didn't load fully before you submitted. Can you repost the video?

@tobi-bams
Copy link
Collaborator Author

Screen.Recording.2024-01-27.at.01.23.11.mov

@ecurrencyhodler

@ecurrencyhodler
Copy link
Contributor

Wow this is so cool that it actually goes through the frontend. It's awesome to see that we were able to get signing in to work!!!

@ecurrencyhodler
Copy link
Contributor

Hey tobi looks like you have prettier tests failing. Can you take another look?

@tobi-bams
Copy link
Collaborator Author

Hey tobi looks like you have prettier tests failing. Can you take another look?

Thanks @ecurrencyhodler, I just fixed that.

@ecurrencyhodler
Copy link
Contributor

All checks pass. Let's get a code review.

Copy link
Collaborator

@Evanfeenstra Evanfeenstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove the nodes.json from git
  • see about running tests in sequence (like login first, then the next test "on top" of that data
  • github action for triggering everything on a PR

@elraphty
Copy link
Collaborator

Screen.Recording.2024-01-27.at.01.23.11.mov
@ecurrencyhodler

Really nice @tobi-bams, you can set the GitHub actions in the .github folder

@tobi-bams
Copy link
Collaborator Author

@elraphty I extended this PR here: link

@tobi-bams tobi-bams merged commit 187a78f into master Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants