Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page name mapping fix #58

Closed
wants to merge 0 commits into from
Closed

Admin Page name mapping fix #58

wants to merge 0 commits into from

Conversation

gouravmpk
Copy link
Contributor

@gouravmpk gouravmpk commented Jan 28, 2024 •
edited
Loading

Describe your changes

Screen.Recording.2024-01-29.at.1.18.47.AM.mov

Missing image from meme.sphinx.chat added and changed button styling
image

Issue ticket number and link

#57

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@gouravmpk
Copy link
Contributor Author

@ecurrencyhodler check this out

@elraphty
Copy link
Collaborator

@gouravmpk tests are not passing

@gouravmpk
Copy link
Contributor Author

gouravmpk commented Jan 28, 2024 •
edited
Loading

@elraphty I got why that test is failing , will fix it soon

@gouravmpk
Copy link
Contributor Author

@elraphty please check now

@ecurrencyhodler
Copy link
Contributor

Jest is still failing.

@kevkevinpal
Copy link
Collaborator

looks like jest if having trouble finding the assignee alias in the test
expect(getByText(bounty.assignee_alias)).toBeInTheDocument();

@kevkevinpal
Copy link
Collaborator

looks like jest if having trouble finding the assignee alias in the test expect(getByText(bounty.assignee_alias)).toBeInTheDocument();

you may need to modify the mock bounties in that test file to include assignee_alias

@gouravmpk gouravmpk requested a review from kevkevinpal January 29, 2024 17:21
@kevkevinpal
Copy link
Collaborator

please cleanup the commits and rebase to master

@ecurrencyhodler ecurrencyhodler added this to the Superadmin milestone Feb 6, 2024
kevkevinpal
kevkevinpal reviewed Feb 6, 2024
View reviewed changes
src/pages/superadmin/tableComponent/__tests__/TableComponent.spec.tsx Outdated
const defaultPage = 1;
const totalBounties = 174;
const paginationLimit = Math.floor(totalBounties / 20) + 1;
const defaultTabs: number[] = [1, 2, 3, 4, 5, 6, 7];
const activeTabs = defaultTabs;
const setActiveTabs = jest.fn();

const mockBounties: Bounty[] = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldnt be changed

Copy link
Contributor Author

@gouravmpk gouravmpk Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I changed it to right place I think

@ecurrencyhodler ecurrencyhodler removed this from the Superadmin milestone Feb 7, 2024
@ecurrencyhodler
Copy link
Contributor

@gouravmpk can you rebase? I'll prioritize this pr for review. Apologies for the ongoing reviews.

@gouravmpk
Copy link
Contributor Author

@gouravmpk can you rebase? I'll prioritize this pr for review. Apologies for the ongoing reviews.

okay

@gouravmpk gouravmpk closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevkevinpal kevkevinpal kevkevinpal left review comments

Assignees
No one assigned
Labels
Superadmin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gouravmpk @elraphty @ecurrencyhodler @kevkevinpal