Fix/1 sync people filter and search

[YLeight]

Handle searching and filtration together

Fix: #1

https://jam.dev/c/0c3e8498-5e22-43d5-b81c-a4a8f526af85

[YLeight]

Blocked by #4 & #6

[ecurrencyhodler]

Video looks good. Sorry one more thing. We have reverted our backend api calls from api.people-test->people.test. So we no longer will require the "api" in front of the call.

Can you push another commit? I think that'll trigger our github actions workflows for testing. Also in the future, you can run the tests locally as well using: yarn run.

[YLeight]

@ecurrencyhodler ✅

[YLeight]

Checking tests

[elraphty]

@YLeight fix Jest and Prettier issues

[ecurrencyhodler]

All checks pass. @elraphty

[YLeight]

I think is better to create new branch from new master as it was updated forcily

[YLeight]

@ecurrencyhodler @elraphty And here we go again

[YLeight]

@ecurrencyhodler @elraphty kindly reminder

[elraphty]

Great work @YLeight, it works well, but the user search by alias call is supposed to make a backend call so it can be a global search, and not an array search check getPeople() in https://github.com/stakwork/sphinx-tribes-frontend/blob/ec15331f75313cfb3dd6a672e4fd4ba480b52ca0/src/store/main.ts, calling the function with a search text is the way to go, thanks.

[YLeight]

Great work @YLeight, it works well, but the user search by alias call is supposed to make a backend call so it can be a global search, and not an array search check getPeople() in https://github.com/stakwork/sphinx-tribes-frontend/blob/ec15331f75313cfb3dd6a672e4fd4ba480b52ca0/src/store/main.ts, calling the function with a search text is the way to go, thanks.

Are you about this place, right?

[YLeight]

Or about this?

[YLeight]

@elraphty Or do you mean its would be better to rewrite old logic with usage of src/people/utils/filterPeople.ts util with real request, by passing all language filters as query params?

[YLeight]

@elraphty Or do you mean its would be better to rewrite old logic with usage of src/people/utils/filterPeople.ts util with real request, by passing all language filters as query params?

Seems like in this case the util function is no more needed, and I can remove is as a legacy code. To avoid not recommended usage in the future.

@elraphty Are we on the same page?

[elraphty]

@elraphty Or do you mean its would be better to rewrite old logic with usage of src/people/utils/filterPeople.ts util with real request, by passing all language filters as query params?

Seems like in this case the util function is no more needed, and I can remove is as a legacy code. To avoid not recommended usage in the future.

@elraphty Are we on the same page?

yeah, we don't need the util function for searching it will only filter 100 users, the people API endpoint already can search if a search query is passed, you can leave the util function for just the skills filter, we will also move the filter search to the backend later, but it is not related to this issue.

[YLeight]

the people API endpoint already can search if a search query is passed

I've used getPeople method from main store, as I can see, this method get search query from ui store.

you can leave the util function for just the skills filter

I've got observed people field from main store which was updated by people setter from getPeople method
And I applied util filterPeople util function for skills filtration of current search result

[YLeight]

@elraphty Tricky content test id on loading conditional rendering

Ready for review

As I've noticed on a meeting, it seems like languages query string should be persistent (stored in a main store)
Since after page refreshing, people data are got from the local storage, but not from the request result, it could lead inconsistent state of ui with empty filters and filtered people data from local storage as it was with search result in stakwork/sphinx-tribes#1437

Can check after people-test.sphinx.chat/people endpoing fix

P.S. Thanks for patience =) Was too excited)

[elraphty]

@elraphty Tricky content test id on loading conditional rendering

Ready for review

As I've noticed on a meeting, it seems like languages query string should be persistent (stored in a main store) Since after page refreshing, people data are got from the local storage, but not from the request result, it could lead inconsistent state of ui with empty filters and filtered people data from local storage as it was with search result in stakwork/sphinx-tribes#1437

Can check after people-test.sphinx.chat/people endpoing fix

P.S. Thanks for patience =) Was too excited)

@YLeight The endpoint is up and running https://people-test.sphinx.chat/people?search=Evan, can you confirm from your end that it works?

[elraphty]

@YLeight

Tested it, this and my findings from this Demo

https://www.loom.com/share/7dc68d5af5ab48c3a81382f770c18a6c

• You can remove the toLowercase on the search input, the backend handles it now
• The Skills are not making any request to the backend, the updated endpoint https://people-test.sphinx.chat/people?search=Evan&languages=Golang,Lightning can search and filter the languages at the same time.

[YLeight]

Seems like backend is again unavailable

[YLeight]

It might help to also rebase and squash.

I do this every day already)

[YLeight]

Awesome, languages now are also a part of url

Thanks to @elraphty

As discussd with @elraphty

I am going to make interactive rebase of the commit history
Make separate PR with husky fix

During this PR were fixed:

• Filter and search on People page isn't synced #1
• Search is reset on people page when mouse is clicked outside of search box #137
  Refactored:
• Clear search when going back to the people page sphinx-tribes#1409
• People Search results are incorrect after the first refreshing the page sphinx-tribes#1437

[ecurrencyhodler]

Okay awesome! do you want to remove this PR from draft? I"m also going to increase your bounties due to the extra work you did. This bounty went from 300k->400k. https://community.sphinx.chat/bounty/1268 Thanks Yegor.

[YLeight]

Today, this request https://people-test.sphinx.chat/people?page=1&resetPage=true&languages=Typescript,Lightning&search=ec&sortBy=last_login&limit=500 responds with incorrect data
Attached video:
https://jam.dev/c/74573792-2400-4918-b550-2bbae443208a

[YLeight]

Implemented uploading synced with filter and search result