Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org name and logo to org home page #92

Closed
wants to merge 15 commits into from

Conversation

NengakDakup
Copy link
Contributor

Describe your changes

image
Added Company Name, Logo, and Description, implemented fallback Logo Image, and conditional render of Organization Links

Issue ticket number and link

#1319

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ecurrencyhodler
Copy link
Contributor

@NengakDakup you have quite a few tests failing. Can you take another look?

@NengakDakup
Copy link
Contributor Author

@NengakDakup you have quite a few tests failing. Can you take another look?

The test i created actually passes when i tested locally, i think the tests failing here are from like other tests...
@kevkevinpal

@aliraza556
Copy link
Contributor

Hi @NengakDakup,
No need add new test file this path src/pages/tickets/org/orgHeader/__tests__/OrgHeaderComponent.spec.tsx
Please see this path test file already added in code:
src/people/widgetViews/__tests__/OrgHeader.spec.tsx

So, remove your test file and move you test code in above path route.

@aliraza556
Copy link
Contributor

@NengakDakup,
Also, no need to create a mock data file.
Some fields add here according to the your requirement (logo, org_name)

@aliraza556
Copy link
Contributor

aliraza556 commented Jan 30, 2024

@NengakDakup see this PR files changes
#26

@NengakDakup
Copy link
Contributor Author

@aliraza556 Noted man. Let me make the corrections. What's your username on sphinx so i chat you up if i still have any issues....

@aliraza556
Copy link
Contributor

Thanks, @NengakDakup! I appreciate your willingness to make the corrections. My username on Sphinx is Ali Raza. Feel free to reach out if you have any more questions or need further assistance.

@ecurrencyhodler
Copy link
Contributor

Hey @NengakDakup looks like you have a conflict with this file: src/pages/tickets/org/orgHeader/index.tsx

@NengakDakup
Copy link
Contributor Author

Hey @NengakDakup looks like you have a conflict with this file: src/pages/tickets/org/orgHeader/index.tsx

Just resolved it

@kevkevinpal
Copy link
Collaborator

it looks like you have 15 different commits, if you can squash them down into fewer commits that will help us review and rebasing the branch onto master will make the tests pass

@NengakDakup
Copy link
Contributor Author

it looks like you have 15 different commits, if you can squash them down into fewer commits that will help us review and rebasing the branch onto master will make the tests pass

okay, man. Noted.

@ecurrencyhodler
Copy link
Contributor

Hey Nen. This issue was taking too long so raph addressed it in #141.

I'm going close this issue and pay you out partially for your work.

@NengakDakup
Copy link
Contributor Author

Hey Nen. This issue was taking too long so raph addressed it in #141.

I'm going close this issue and pay you out partially for your work.

Okay, man. Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants