-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org name and logo to org home page #92
Conversation
@NengakDakup you have quite a few tests failing. Can you take another look? |
The test i created actually passes when i tested locally, i think the tests failing here are from like other tests... |
Hi @NengakDakup, So, remove your test file and move you test code in above path route. |
@NengakDakup, |
@NengakDakup see this PR files changes |
@aliraza556 Noted man. Let me make the corrections. What's your username on sphinx so i chat you up if i still have any issues.... |
Thanks, @NengakDakup! I appreciate your willingness to make the corrections. My username on Sphinx is |
Hey @NengakDakup looks like you have a conflict with this file: src/pages/tickets/org/orgHeader/index.tsx |
Just resolved it |
it looks like you have 15 different commits, if you can squash them down into fewer commits that will help us review and rebasing the branch onto master will make the tests pass |
okay, man. Noted. |
Hey Nen. This issue was taking too long so raph addressed it in #141. I'm going close this issue and pay you out partially for your work. |
Okay, man. Great! |
Describe your changes
Added Company Name, Logo, and Description, implemented fallback Logo Image, and conditional render of Organization Links
Issue ticket number and link
#1319
Type of change
Please delete options that are not relevant.
Checklist before requesting a review