Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: description box for org home page #1433

Closed
wants to merge 6 commits into from
Closed

feat: description box for org home page #1433

wants to merge 6 commits into from

Conversation

Khaalid-oh
Copy link
Contributor

Screenshot 2024-01-22 at 15 50 34

Created description box for org home page

[Issue ticket number and link

](#1318)

UI Implementation

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@ecurrencyhodler
Copy link
Contributor

@Khaalid-oh some jest tests are failing. Can you address that?

@Khaalid-oh
Copy link
Contributor Author

Khaalid-oh commented Jan 22, 2024

@Khaalid-oh some jest tests are failing. Can you address that?

I commented out my code and ran the test and those tests are still failing. I'm currently looking into how they can be improved to pass

@ecurrencyhodler
Copy link
Contributor

Have you tried rebasing?

@Khaalid-oh
Copy link
Contributor Author

I ran the test on the master branch without my changes and those tests were still failing actually

@ecurrencyhodler
Copy link
Contributor

Hi! can you resubmit this PR to this new frontend repo? https://github.com/stakwork/sphinx-tribes-frontend

Also raph is fixing the tests you pointed out. Thanks for raising that.

@ecurrencyhodler
Copy link
Contributor

New api endpoint for our backend is: https://api.people-test.sphinx.chat/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants