Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Filters on homepage aren't working properly #1501

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

wright-eric
Copy link
Contributor

@wright-eric wright-eric commented Feb 10, 2024

Describe your changes

Filters on homepage aren't working properly

Issue ticket number and link

closes #1498

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@wright-eric
Copy link
Contributor Author

@ecurrencyhodler would do some testing tomorrow and will give the MR for review then.

@ecurrencyhodler
Copy link
Contributor

Can you post a video of selecting various skill filters locally from the home page?

@Vayras
Copy link
Contributor

Vayras commented Feb 12, 2024

Hey! @wright-eric do you have an update on this issue?

@ecurrencyhodler
Copy link
Contributor

@elraphty Let's review and merge tomorrow if:

  1. eric doesn't respond by tomorrow
  2. code and tests look good

If there are other issues, we can handle it outside of this PR

@ecurrencyhodler
Copy link
Contributor

Eric said we can merge this if we want.

@elraphty
Copy link
Contributor

Eric said we can merge this if we want.

Tested, and merging

@elraphty elraphty merged commit fe0bbed into stakwork:master Feb 15, 2024
1 check passed
@ecurrencyhodler
Copy link
Contributor

Paid 200k stats! https://community.sphinx.chat/bounty/1435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters on homepage aren't working properly
4 participants