Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend [Integration Test] bounty.go handlers GetBountyByCreated, GetNextBountyByCreated, GetPreviousBountyByCreated, GetOrganizationNextBountyByCreated, & GetOrganizationPreviousBountyByCreated #1525

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

AbdulWahab3181
Copy link
Contributor

Describe your changes

Added Unit test for bounty handler to test GetBountyByCreated, GetNextBountyByCreated, GetPreviousBountyByCreated, GetOrganizationNextBountyByCreated and GetOrganizationPreviousBountyByCreated methods

Issue ticket number and link

Closes #1517

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@AbdulWahab3181 AbdulWahab3181 marked this pull request as ready for review February 17, 2024 07:33
@aliraza556
Copy link
Contributor

Hi @AbdulWahab3181
Excellent work on the test suite! It's thorough, impeccably organized, and highlights your remarkable testing expertise. You've effectively ensured extensive coverage and upheld superior code standards, illustrating exceptional proficiency in testing.

db db.Database
httpClient HttpClient
db db.Database
generateBountyHandler func(bounties []db.Bounty) []db.BountyResponse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbdulWahab3181 change this to generateResponse, generateBountyHandler, sounds a bit misleading.

Copy link
Contributor Author

@AbdulWahab3181 AbdulWahab3181 Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elraphty Addressed

@elraphty elraphty merged commit f71fe4e into stakwork:master Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants