Backend [Integration Test] people.go handlers GetPeopleBySearch, GetListedPeople, & GetPersonByUuid #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elraphty
reviewed
Feb 20, 2024
handlers/people_test.go
Outdated
| } | ||
|
|
||
| rctx := chi.NewRouteContext() | ||
| rctx.URLParams.Add("search", "John") |
There was a problem hiding this comment.
@AbdulWahab3181 the search should be in the URL query, not param.
There was a problem hiding this comment.
@elraphty Addressed
handlers/people_test.go
Outdated
| expectedPeople := []db.Person{} | ||
|
|
||
| rctx := chi.NewRouteContext() | ||
| rctx.URLParams.Add("search", "user not matched") |
There was a problem hiding this comment.
@AbdulWahab3181 the search should be in the URL query, not param.
handlers/people_test.go
Outdated
|
|
||
| rctx := chi.NewRouteContext() | ||
| rctx.URLParams.Add("page", "1") | ||
| rctx.URLParams.Add("limit", "10") |
There was a problem hiding this comment.
@AbdulWahab3181 the limit and page should be in the URL query, not param.
handlers/people_test.go
Outdated
| } | ||
|
|
||
| rctx := chi.NewRouteContext() | ||
| rctx.URLParams.Add("page", "1") |
There was a problem hiding this comment.
@AbdulWahab3181 the limit, page, and search should be in the URL query, not param.
handlers/people_test.go
Outdated
| rctx := chi.NewRouteContext() | ||
| rctx.URLParams.Add("page", "1") | ||
| rctx.URLParams.Add("limit", "10") | ||
| rctx.URLParams.Add("languages", "typescript") |
There was a problem hiding this comment.
@AbdulWahab3181 the page, limit, and languages should be in the URL query, not the param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added Unit test for people handler to test GetPeopleBySearch, GetListedPeople and GetPersonByUuid methods
Issue ticket number and link
Closes #1518
Type of change
Please delete options that are not relevant.
Checklist before requesting a review