Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Endpoints and properties to Workspaces/Organizations #1616

Conversation

AbdulWahab3181
Copy link
Contributor

@AbdulWahab3181 AbdulWahab3181 commented Apr 25, 2024

Describe your changes

Add Endpoints and properties to Workspaces/Organizations

image

Issue ticket number and link

Closes #1615

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@AbdulWahab3181 AbdulWahab3181 marked this pull request as ready for review April 25, 2024 07:41
@AbdulWahab3181
Copy link
Contributor Author

Note:

I have created different handler methods for different endpoints, each performing the same logic. I assume these methods will be updated in the future and have their own unique logics. Please let me know if you want any modifications to the code or if you would like me to create a single method for all three endpoints

@elraphty
Copy link
Contributor

Note:

I have created different handler methods for different endpoints, each performing the same logic. I assume these methods will be updated in the future and have their own unique logics. Please let me know if you want any modifications to the code or if you would like me to create a single method for all three endpoints

@AbdulWahab3181, one handler can handle the 3 of them, it's the same Logic all through, we should try to avoid repetition.

return
}

workspace := db.Organization{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change db.Organization to db.Workspace, pull from master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

return
}

workspace := db.Organization{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change db.Organization to db.Workspace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

return
}

workspace := db.Organization{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change db.Organization to db.Workspace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

@AbdulWahab3181
Copy link
Contributor Author

Note:
I have created different handler methods for different endpoints, each performing the same logic. I assume these methods will be updated in the future and have their own unique logics. Please let me know if you want any modifications to the code or if you would like me to create a single method for all three endpoints

@AbdulWahab3181, one handler can handle the 3 of them, it's the same Logic all through, we should try to avoid repetition.

@elraphty Addressed

image

@elraphty
Copy link
Contributor

Note:
I have created different handler methods for different endpoints, each performing the same logic. I assume these methods will be updated in the future and have their own unique logics. Please let me know if you want any modifications to the code or if you would like me to create a single method for all three endpoints

@AbdulWahab3181, one handler can handle the 3 of them, it's the same Logic all through, we should try to avoid repetition.

@elraphty Addressed

image

reviewing.

@elraphty
Copy link
Contributor

@AbdulWahab3181 these

	Mission string         `json:"mission"`
	Tactics string         `json:"tactics"`
	SchematicUrl string    `json:"schematic_url"`

are supposed to be in the Workspace struct and not Organization, the organization table has been renamed to workspace.

@AbdulWahab3181
Copy link
Contributor Author

@AbdulWahab3181 these

	Mission string         `json:"mission"`
	Tactics string         `json:"tactics"`
	SchematicUrl string    `json:"schematic_url"`

are supposed to be in the Workspace struct and not Organization, the organization table has been renamed to workspace.

@elraphty Addressed

@AbdulWahab3181 AbdulWahab3181 force-pushed the feature/add-workspace-endpoints branch from 55d5d80 to 64ff914 Compare April 25, 2024 15:33
@elraphty
Copy link
Contributor

@AbdulWahab3181 did you alter the GitHub workflow? each commit is supposed to trigger a GitHub workflow, your PR has 0 checks.

@elraphty
Copy link
Contributor

@AbdulWahab3181 did you alter the GitHub workflow? each commit is supposed to trigger a GitHub workflow, your PR has 0 checks.

oh! sorry the workflow is configured to be triggered for only the master branch.

@elraphty
Copy link
Contributor

@AbdulWahab3181 did you rebase to master or merge master to your branch?

@AbdulWahab3181
Copy link
Contributor Author

@AbdulWahab3181 did you rebase to master or merge master to your branch?

Merge master to my branch

@elraphty
Copy link
Contributor

@AbdulWahab3181 did you rebase to master or merge master to your branch?

Merge master to my branch

Next time rebase or squash merge, to remove the commit history, it becomes difficult to review with lots of commit histories.

@AbdulWahab3181
Copy link
Contributor Author

Next time rebase or squash merge, to remove the commit history, it becomes difficult to review with lots of commit histories.

Understood, I'll use rebase or squash merge next time

@elraphty
Copy link
Contributor

@AbdulWahab3181 your change is breaking the cypress test

@AbdulWahab3181
Copy link
Contributor Author

@elraphty Resolved

@AbdulWahab3181
Copy link
Contributor Author

@AbdulWahab3181 these

	Mission string         `json:"mission"`
	Tactics string         `json:"tactics"`
	SchematicUrl string    `json:"schematic_url"`

are supposed to be in the Workspace struct and not Organization, the organization table has been renamed to workspace.

I've added Mission, Tactics, and SchematicUrl fields inside the Organization struct, as shown in 9af491b. These fields in the Organization struct are used to create columns within the Workspace table.

@elraphty elraphty merged commit d1fa4f1 into stakwork:feature-add-features-endpoints Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants