-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Endpoints and properties to Workspaces/Organizations #1616
Add Endpoints and properties to Workspaces/Organizations #1616
Conversation
added count to budget and added workspace/next endpoint
…rkspace Changed organization to workspace
Note: I have created different handler methods for different endpoints, each performing the same logic. I assume these methods will be updated in the future and have their own unique logics. Please let me know if you want any modifications to the code or if you would like me to create a single method for all three endpoints |
@AbdulWahab3181, one handler can handle the 3 of them, it's the same Logic all through, we should try to avoid repetition. |
handlers/workspaces.go
Outdated
return | ||
} | ||
|
||
workspace := db.Organization{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change db.Organization to db.Workspace, pull from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
handlers/workspaces.go
Outdated
return | ||
} | ||
|
||
workspace := db.Organization{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change db.Organization to db.Workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
handlers/workspaces.go
Outdated
return | ||
} | ||
|
||
workspace := db.Organization{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change db.Organization to db.Workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
@elraphty Addressed |
reviewing. |
@AbdulWahab3181 these Mission string `json:"mission"`
Tactics string `json:"tactics"`
SchematicUrl string `json:"schematic_url"` are supposed to be in the |
@elraphty Addressed |
55d5d80
to
64ff914
Compare
@AbdulWahab3181 did you alter the GitHub workflow? each commit is supposed to trigger a GitHub workflow, your PR has 0 checks. |
oh! sorry the workflow is configured to be triggered for only the master branch. |
@AbdulWahab3181 did you rebase to master or merge master to your branch? |
Merge master to my branch |
Next time rebase or squash merge, to remove the commit history, it becomes difficult to review with lots of commit histories. |
Understood, I'll use rebase or squash merge next time |
@AbdulWahab3181 your change is breaking the cypress test |
@elraphty Resolved |
I've added Mission, Tactics, and SchematicUrl fields inside the Organization struct, as shown in 9af491b. These fields in the Organization struct are used to create columns within the Workspace table. |
d1fa4f1
into
stakwork:feature-add-features-endpoints
Describe your changes
Add Endpoints and properties to Workspaces/Organizations
Issue ticket number and link
Closes #1615
Type of change
Please delete options that are not relevant.
Checklist before requesting a review