Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fields to Create Connection Modal and Integrate Backend Workflow #2161

Closed

Conversation

aliraza556
Copy link
Contributor

@aliraza556 aliraza556 commented Dec 12, 2024

Describe your changes

Issue ticket number and link: #2159

Closed: #2159

image

image

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@humansinstitute
Copy link
Contributor

@tobi-bams can you look at this?
@aliraza556 Looks like we have some test failures?

@aliraza556
Copy link
Contributor Author

Hi @humansinstitute @tobi-bams,

Please review this PR. My unit tests have passed, but I suspect there might be a payment issue error, possibly related to the work @Evanfeenstra has been doing on this payment issue. Additionally, in this PR (#2166), there are no changes in the code, yet both the unit tests and Cypress tests have failed.

@aliraza556 aliraza556 force-pushed the feat-connection-codes-payment branch from 23fa547 to 19b65a4 Compare December 12, 2024 23:43
@aliraza556
Copy link
Contributor Author

Hi @humansinstitute, @elraphty, Please review this PR.

@aliraza556
Copy link
Contributor Author

Hi @humansinstitute Please review it here #2179

@aliraza556 aliraza556 closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Fields to Create Connection Modal and Integrate Backend Workflow
2 participants