Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a logger util #2225

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Create a logger util #2225

merged 2 commits into from
Dec 19, 2024

Conversation

MahtabBukhari
Copy link
Contributor

Describe your changes

Issue ticket number: #2185

Link

Close: #2185

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@MahtabBukhari
Copy link
Contributor Author

@kevkevinpal Could you please review the PR?

@kevkevinpal
Copy link
Contributor

I modified the code so we can just use utils.Log.Error instead of having to instantiate it first

but otherwise the code looks good!

@kevkevinpal kevkevinpal merged commit efdcbc9 into stakwork:master Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a logger util
2 participants
@MahtabBukhari @kevkevinpal