Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move y-033 to typo function, move t-004 #645

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

vr8hub
Copy link
Contributor

@vr8hub vr8hub commented Feb 9, 2024

Y-033 was added while the restructure was in-progress, and I apparently didn't get it into the correct function when I rebased.

I also left t-004 out of order, this just moves it up where it should be. There's some more re-ordering that needs to be done, but it's more extensive so I'll leave it for later.

I'm going to start looking at creating some additional lint tests, starting with the most complicated, e.g. maybe the couple identified in the instrumentation tests in #623, t-003, etc. Ones with multiple steps and/or ones with really complicated xpaths. If you have ones you're most interested in, let me know.

@acabal
Copy link
Member

acabal commented Feb 9, 2024

Thanks! No input on the tests, in an ideal world there would be full coverage so you can start wherever you like. Probably the simpler ones will be easiest because some of the more complex ones test to exclude false positives, which may not be very well documented.

@acabal acabal merged commit 0c78865 into standardebooks:master Feb 9, 2024
1 check passed
@vr8hub vr8hub deleted the msgorder branch February 17, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants