Tweak some accessibility conformance claims #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acabal
requested changes
Mar 10, 2024
New features in WCAG 2.2: https://www.w3.org/TR/WCAG22/#new-features-in-wcag-2-2 - 2.4.11 doesn’t apply to us - 2.4.12 doesn’t apply to us - 2.4.13 is based on the ereader’s styles - 2.5.7 doesn’t apply to us - 2.5.8 we have an out on, as all of our links are inline - 3.2.6 doesn’t apply to us - 3.3.7 doesn’t apply to us - 3.3.8 doesn’t apply to us - 3.3.9 doesn’t apply to us
…ilds We’re converting away from MathML there so it’s no longer accurate.
robinwhittleton
force-pushed
the
wcag-22
branch
2 times, most recently
from
c66ca9b to
3511e55
Compare
|
Can you fix the mypy errors that came up during the merge checks? |
robinwhittleton
force-pushed
the
wcag-22
branch
from
3511e55 to
8bf7b76
Compare
geckodriver was vendored in, but only as an ELF binary which aren’t natively compatible on Macs. This adds ARM and Intel binaries for Mac and a Windows Intel binary too, and falls back to checking the path for other machines.
robinwhittleton
force-pushed
the
wcag-22
branch
from
8bf7b76 to
1081a54
Compare
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
MathMLanddescribedMathaccessibility features where appropriateIt also updates the build process to strip
MathMLanddescribedMathaccessibility features from the compatible builds, and gets MathML building working again on non-Linux systems.I guess we’ll want to update books with MathML with these new functionality, but we should wait until we’re building with this code.