Revert "Improve t-041, add period to list of checked punctuation" #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5b017a2.
|
But this reverts the check... did you mean to revert the test instead? |
|
No, it’s my running grep against the corpus for the check that I screwed up. Way too many false positives result with the period in there. |
|
OK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5b017a2.
So sorry, Alex, I had a stupid typo in my test, and this needs to be reverted. Lesson learned: I'll just test with lint from now on rather than trying to save (granted, a lot of) time testing the regexes/xpath themselves.