Improve t-074 and its test #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the t-074 test to look for two consecutive single characters surrounded by dashes. As detailed in our discussion on the other PR, a single character between dashes finds more false positives than using two characters misses (e.g. this will allow to get rid of five ignore files that had to be created today).
I also got rid of the length limit, on the presumption that at least two characters is pretty likely to be a valid hit wherever it's found. (A run on the corpus turned up no false positives.)
(I had already done all this before I tried to pull the PR and saw you had made further changes to the test. Since I had covered more exclusions and had valid entries as well, I went ahead and left my test as it was. It covers everything yours did and more.)
I think a search for a "word" entirely consisting of single-characters and dashes is still something lint can try to catch, but I need to do some more testing before I propose anything. One of the problems is that what's found could be either an unitalicized sound (O-w-w-w-w) or a spelled-out word (w-o-r-d) without grapheme/phoneme tags on the letters, so the message will need to be ambiguous.