Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize aërial -> aerial #762

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Modernize aërial -> aerial #762

merged 2 commits into from
Oct 31, 2024

Conversation

robinwhittleton
Copy link
Member

There‘s an obvious trend in ngrams for this: https://books.google.com/ngrams/graph?content=a%C3%ABrial%2Caerial&year_start=1800&year_end=2022&corpus=en&smoothing=3

Looking at the corpus, 19 productions currently use this; will modernize if this is merged.

@acabal acabal merged commit b305e96 into master Oct 31, 2024
2 checks passed
@acabal
Copy link
Member

acabal commented Oct 31, 2024

OK, thanks!

@robinwhittleton robinwhittleton deleted the modernize-aerial branch October 31, 2024 16:06
@robinwhittleton robinwhittleton restored the modernize-aerial branch October 31, 2024 16:07
@robinwhittleton
Copy link
Member Author

Oh, damn, looks like I branched off the wrong branch for this. Are you OK with the y-024 change, or do you want me rework this? Sorry!

@acabal
Copy link
Member

acabal commented Oct 31, 2024

Yes, it's fine, I assume you checked against the corpus already to make sure there's not too many false positives

@robinwhittleton
Copy link
Member Author

No false positives that I’ve seen, apart from Ulysses (surprise surprise).

@robinwhittleton robinwhittleton deleted the modernize-aerial branch October 31, 2024 16:10
@robinwhittleton
Copy link
Member Author

Oh, and Ozma of Oz, where Tiktok speaks like this:

I can-not help be-ing your in-fer-i-or for I am a mere ma-chine.

But potentially those should be non-breaking hyphens anyway?

@acabal
Copy link
Member

acabal commented Oct 31, 2024

Possibly but I think all of his dialogue is like that and it would be pretty hard to find all the cases, and then we could wind up with words not being broken across lines correctly if he has many sentences like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants